Skip to content

Commit

Permalink
Amend validate.sh and github workflows to not call make-cabal-install…
Browse files Browse the repository at this point in the history
…-dev
  • Loading branch information
emilypi committed Apr 14, 2021
1 parent f8e2383 commit 59b2fe5
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 26 deletions.
14 changes: 0 additions & 14 deletions .github/workflows/linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,6 @@ jobs:
run: sh validate.sh -j 2 -w ghc-8.10.1 -v -s print-config
- name: Validate print-tool-versions
run: sh validate.sh -j 2 -w ghc-8.10.1 -v -s print-tool-versions
- name: Validate make-cabal-install-dev
run: sh validate.sh -j 2 -w ghc-8.10.1 -v -s make-cabal-install-dev
- name: Validate build
run: sh validate.sh -j 2 -w ghc-8.10.1 -v -s build
- name: Validate lib-tests
Expand Down Expand Up @@ -140,8 +138,6 @@ jobs:
run: sh validate.sh -j 2 -w ghc-8.8.3 -v --solver-benchmarks -s print-config
- name: Validate print-tool-versions
run: sh validate.sh -j 2 -w ghc-8.8.3 -v --solver-benchmarks -s print-tool-versions
- name: Validate make-cabal-install-dev
run: sh validate.sh -j 2 -w ghc-8.8.3 -v --solver-benchmarks -s make-cabal-install-dev
- name: Validate build
run: sh validate.sh -j 2 -w ghc-8.8.3 -v --solver-benchmarks -s build
- name: Validate lib-tests
Expand Down Expand Up @@ -188,8 +184,6 @@ jobs:
run: sh validate.sh -j 2 -w ghc-8.6.5 -v --complete-hackage-tests -s print-config
- name: Validate print-tool-versions
run: sh validate.sh -j 2 -w ghc-8.6.5 -v --complete-hackage-tests -s print-tool-versions
- name: Validate make-cabal-install-dev
run: sh validate.sh -j 2 -w ghc-8.6.5 -v --complete-hackage-tests -s make-cabal-install-dev
- name: Validate build
run: sh validate.sh -j 2 -w ghc-8.6.5 -v --complete-hackage-tests -s build
- name: Validate lib-tests
Expand Down Expand Up @@ -236,8 +230,6 @@ jobs:
run: sh validate.sh -j 2 -w ghc-8.4.4 -v -s print-config
- name: Validate print-tool-versions
run: sh validate.sh -j 2 -w ghc-8.4.4 -v -s print-tool-versions
- name: Validate make-cabal-install-dev
run: sh validate.sh -j 2 -w ghc-8.4.4 -v -s make-cabal-install-dev
- name: Validate build
run: sh validate.sh -j 2 -w ghc-8.4.4 -v -s build
- name: Validate lib-tests
Expand Down Expand Up @@ -284,8 +276,6 @@ jobs:
run: sh validate.sh -j 2 -w ghc-8.2.2 -v -s print-config
- name: Validate print-tool-versions
run: sh validate.sh -j 2 -w ghc-8.2.2 -v -s print-tool-versions
- name: Validate make-cabal-install-dev
run: sh validate.sh -j 2 -w ghc-8.2.2 -v -s make-cabal-install-dev
- name: Validate build
run: sh validate.sh -j 2 -w ghc-8.2.2 -v -s build
- name: Validate lib-tests
Expand Down Expand Up @@ -332,8 +322,6 @@ jobs:
run: sh validate.sh -j 2 -w ghc-8.0.2 -v -s print-config
- name: Validate print-tool-versions
run: sh validate.sh -j 2 -w ghc-8.0.2 -v -s print-tool-versions
- name: Validate make-cabal-install-dev
run: sh validate.sh -j 2 -w ghc-8.0.2 -v -s make-cabal-install-dev
- name: Validate build
run: sh validate.sh -j 2 -w ghc-8.0.2 -v -s build
- name: Validate lib-tests
Expand Down Expand Up @@ -380,8 +368,6 @@ jobs:
run: sh validate.sh -j 2 -w ghc-7.10.3 -v -s print-config
- name: Validate print-tool-versions
run: sh validate.sh -j 2 -w ghc-7.10.3 -v -s print-tool-versions
- name: Validate make-cabal-install-dev
run: sh validate.sh -j 2 -w ghc-7.10.3 -v -s make-cabal-install-dev
- name: Validate build
run: sh validate.sh -j 2 -w ghc-7.10.3 -v -s build
- name: Validate lib-tests
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ jobs:
run: sh validate.sh -j 2 -w ghc-8.8.3 -v -s print-config
- name: Validate print-tool-versions
run: sh validate.sh -j 2 -w ghc-8.8.3 -v -s print-tool-versions
- name: Validate make-cabal-install-dev
run: sh validate.sh -j 2 -w ghc-8.8.3 -v -s make-cabal-install-dev
- name: Validate build
run: sh validate.sh -j 2 -w ghc-8.8.3 -v -s build
- name: Validate lib-tests
Expand Down Expand Up @@ -112,8 +110,6 @@ jobs:
run: sh validate.sh -j 2 -w ghc-8.6.5 -v -s print-config
- name: Validate print-tool-versions
run: sh validate.sh -j 2 -w ghc-8.6.5 -v -s print-tool-versions
- name: Validate make-cabal-install-dev
run: sh validate.sh -j 2 -w ghc-8.6.5 -v -s make-cabal-install-dev
- name: Validate build
run: sh validate.sh -j 2 -w ghc-8.6.5 -v -s build
- name: Validate lib-tests
Expand Down
9 changes: 1 addition & 8 deletions validate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ fi

if [ -z "$STEPS" ]; then
STEPS="print-config print-tool-versions"
if ! $LIBONLY; then STEPS="$STEPS make-cabal-install-dev"; fi
STEPS="$STEPS build"
if $DOCTEST; then STEPS="$STEPS doctest"; fi
if $LIBTESTS; then STEPS="$STEPS lib-tests"; fi
Expand Down Expand Up @@ -359,11 +358,6 @@ step_time_summary() {
# build
#######################################################################

step_make_cabal_install_dev() {
print_header "make cabal-install-dev"
timed cp cabal-install/cabal-install.cabal.dev cabal-install/cabal-install.cabal
}

step_build() {
print_header "build"
timed $CABALNEWBUILD $TARGETS --dry-run || exit 1
Expand Down Expand Up @@ -487,7 +481,6 @@ for step in $STEPS; do
case $step in
print-config) step_print_config ;;
print-tool-versions) step_print_tool_versions ;;
make-cabal-install-dev) step_make_cabal_install_dev ;;
build) step_build ;;
doctest) step_doctest ;;
lib-tests) step_lib_tests ;;
Expand All @@ -498,7 +491,7 @@ for step in $STEPS; do
solver-benchmarks-tests) step_solver_benchmarks_tests ;;
solver-benchmarks-run) step_solver_benchmarks_run ;;
time-summary) step_time_summary ;;
*)
*)
echo "Invalid step $step"
exit 1
;;
Expand Down

0 comments on commit 59b2fe5

Please sign in to comment.