Merge pull request #7847 from Daem0n-th/fix-post-checkout-cmd-bug

Fix #7641 : Fix `post-checkout-command` bug

cabal-install/src/Distribution/Client/ProjectConfig.hs

@@ -1192,7 +1192,7 @@ syncAndReadSourcePackagesRemoteRepos verbosity
         for_ repoGroupWithPaths $ \(repo, _, repoPath) ->
             for_ (nonEmpty (srpCommand repo)) $ \(cmd :| args) -> liftIO $ do
                 exitCode <- rawSystemIOWithEnv verbosity cmd args (Just repoPath) Nothing Nothing Nothing Nothing
-                unless (exitCode /= ExitSuccess) $ exitWith exitCode
+                unless (exitCode == ExitSuccess) $ exitWith exitCode
 
         -- But for reading we go through each 'SourceRepo' including its subdir
         -- value and have to know which path each one ended up in.

cabal-testsuite/PackageTests/postCheckoutCommand/cabal.negative.project

@@ -0,0 +1,8 @@
+packages: .
+
+source-repository-package
+    type: git
+-- A Sample repo to test post-checkout-command
+    location: https://github.com/haskell/bytestring 
+    post-checkout-command: false
+-- https://en.wikipedia.org/wiki/True_and_false_(commands)

cabal-testsuite/PackageTests/postCheckoutCommand/cabal.out

@@ -0,0 +1,2 @@
+# cabal v2-build
+# cabal v2-build

cabal-testsuite/PackageTests/postCheckoutCommand/cabal.positive.project

@@ -0,0 +1,8 @@
+packages: .
+
+source-repository-package
+    type: git
+-- A Sample repo to test post-checkout-command
+    location: https://github.com/haskell/bytestring
+    post-checkout-command: true
+-- https://en.wikipedia.org/wiki/True_and_false_(commands)

cabal-testsuite/PackageTests/postCheckoutCommand/cabal.test.hs

@@ -0,0 +1,8 @@
+import Test.Cabal.Prelude
+
+main = cabalTest $ do
+    skipIfWindows 
+    withProjectFile "cabal.positive.project" $ do
+        cabal "v2-build" ["-v0"]
+    withProjectFile "cabal.negative.project" $ do
+        fails $ cabal "v2-build" ["-v0"]

cabal-testsuite/PackageTests/postCheckoutCommand/example.cabal

@@ -0,0 +1,9 @@
+cabal-version:      2.4
+name:               example
+version:            1.0
+
+library
+    exposed-modules:  Example
+    build-depends:    base
+    hs-source-dirs:   src
+    default-language: Haskell2010

cabal-testsuite/PackageTests/postCheckoutCommand/src/Example.hs

@@ -0,0 +1,4 @@
+module Example (someFunc) where
+
+someFunc :: IO ()
+someFunc = putStrLn "Example"

changelog.d/issue-7641

@@ -0,0 +1,4 @@
+synopsis: Fix post-checkout-command crash when 0 exit status bug
+issues: #7641
+packages: cabal-install
+prs: #7847