Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #478.
I wanted to share some code between strict
unlines
and strictintercalate
, but wasn't able to easily get the singleton-copying to rewrite to apoke
or similar, resulting in a performance hit. I think this level of duplication is acceptable.My idea to make
Lazy.concat
fuse with the existing lazyunlines
definition was a slight improvement, but just writing the fused fold manually produced bigger gains. I think this is because now no attempt is made to iterate over a singleton.Benchmark results:
master:
topic branch: