Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for #393 #394

Merged
merged 2 commits into from
May 31, 2021
Merged

Add test for #393 #394

merged 2 commits into from
May 31, 2021

Conversation

phadej
Copy link
Contributor

@phadej phadej commented May 24, 2021

Test for #393

@Bodigrim
Copy link
Contributor

Sorry, I'm a bit overloaded this week and the next one. @sjakobi @bgamari if you possibly happen to have time to take a look earlier, feel free to merge or whatever without waiting for me. Is it connected to #191 or #132?

@Bodigrim
Copy link
Contributor

git bisect points to d701a2a, and indeed reverting that commit makes the test pass. But I do not understand why, the commit seems absolutely legit. CC @ethercrow

@phadej
Copy link
Contributor Author

phadej commented May 27, 2021

Should I add a revert of the d701a2a to this PR?

@Bodigrim
Copy link
Contributor

Yes, probably. It would be easier to investigate further with the test merged, and it unblocks your work on Lift instance.

Looks like a GHC 9.0 bug, it would be nice to file an issue there. E. g., this passes:

    fromString ("\0\1\2" ++ "\3\4") == B.pack [0,1,2,3,4]

@phadej
Copy link
Contributor Author

phadej commented May 27, 2021 •
edited
Loading

Reverted, CI is green.

@phadej
Copy link
Contributor Author

phadej commented May 29, 2021

ping

@phadej
Copy link
Contributor Author

phadej commented May 30, 2021

This and #390 pull requests are accepted, what is required to get them merged?

@Bodigrim Bodigrim requested a review from sjakobi May 30, 2021 14:32
@Bodigrim Bodigrim merged commit ad752c9 into haskell:master May 31, 2021
@Bodigrim Bodigrim added this to the 0.11.2.0 milestone Jun 10, 2021
@Bodigrim
Copy link
Contributor

Filed as https://gitlab.haskell.org/ghc/ghc/-/issues/19976

@phadej phadej deleted the test-for-393 branch October 10, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

@Bodigrim Bodigrim Bodigrim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@phadej @Bodigrim @sjakobi