Add StrictByteString & LazyByteString type aliases #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
reviewed
Mar 18, 2021
|
No, you're right, this is an oversight from my part |
Kleidukos
force-pushed
the
add-type-aliases
branch
from
57d92a1 to
1f0af0d
Compare
|
@sjakobi Should be good! |
sjakobi
reviewed
Mar 18, 2021
Kleidukos
force-pushed
the
add-type-aliases
branch
from
1f0af0d to
df996e1
Compare
Bodigrim
reviewed
Mar 19, 2021
Data/ByteString/Lazy/Internal.hs
Outdated
| @@ -80,6 +81,9 @@ data ByteString = Empty | Chunk {-# UNPACK #-} !S.ByteString ByteString | |||
| deriving (Typeable) | |||
| -- See 'invariant' function later in this module for internal invariants. | |||
|
|
|||
| -- | Type synonym for the lazy flavour of ByteString | |||
There was a problem hiding this comment.
Suggested change
| -- | Type synonym for the lazy flavour of ByteString | |
| -- | Type synonym for the lazy flavour of 'ByteString'. |
And same for the strict one, please.
Data/ByteString.hs
Outdated
| @@ -40,8 +40,9 @@ | |||
|
|
|||
| module Data.ByteString ( | |||
|
|
|||
| -- * The @ByteString@ type | |||
| -- * The strict @ByteString@ type and its associated type alias | |||
There was a problem hiding this comment.
I'm afraid this is too long for a side bar table of contents in Haddock, it takes 5 lines.
Suggested change
| -- * The strict @ByteString@ type and its associated type alias | |
| -- * Strict @ByteString@ |
Kleidukos
force-pushed
the
add-type-aliases
branch
from
df996e1 to
a7d231e
Compare
Kleidukos
force-pushed
the
add-type-aliases
branch
from
a7d231e to
de3a43e
Compare
Bodigrim
approved these changes
Mar 19, 2021
|
Thank you, @Kleidukos! :) |
Bodigrim
pushed a commit
to Bodigrim/bytestring
that referenced
this pull request
May 16, 2021
noughtmare
pushed a commit
to noughtmare/bytestring
that referenced
this pull request
Dec 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Bodigrim
closes #375