Run CI job in a FreeBSD VM #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! |
Bodigrim
reviewed
Nov 15, 2020
| @@ -50,3 +52,22 @@ jobs: | |||
| cd bench | |||
| cabal bench -O0 --benchmark-options "--quick --min-duration=0 --include-first-iter" | |||
|
|
|||
| build-freebsd: | |||
| runs-on: macos-latest | |||
There was a problem hiding this comment.
MacOS is the most expensive system to run with 10x minute multiplier. Could we use Ubuntu or Windows instead?
There was a problem hiding this comment.
Yeah, I wondered the same, but this action's documentation says that only macOS has the necessary virtualization features.
There was a problem hiding this comment.
Then we should add a comment indicating this with a link to the documentation.
Bodigrim
approved these changes
Nov 15, 2020
|
@ethercrow thanks! |
Bodigrim
pushed a commit
to Bodigrim/bytestring
that referenced
this pull request
Nov 17, 2020
* Run CI job in a FreeBSD VM * Explanation why the freebsd job is running on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Bodigrim @vdukhovni I've found a Github Action that runs FreeBSD inside a VirtualBox: https://github.com/vmactions/freebsd-vm