Tweak compareLength rules #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
approved these changes
Oct 27, 2020
| #-} | ||
|
|
||
| {-# RULES | ||
| compare n (length t) = compare EQ $ compareLength t n |
There was a problem hiding this comment.
This is not a readability improvement IMHO, but I don't care too much.
There was a problem hiding this comment.
A comment could be added that compare EQ LT = GT and vice versa. Would that be helpful? I just didn't see a need to define a new function for this...
There was a problem hiding this comment.
Yeah, that comment would be helpful. 👍
- Consolidate RULES pragmas - Replace `negateOrdering` with `compare EQ`.
vdukhovni
force-pushed
the
ordering-rules
branch
from
bd62569 to
83e41e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
negateOrderingwithcompare EQ.