Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to base430 #305

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Remove references to base430 #305

merged 3 commits into from
Oct 12, 2020

Conversation

elikoga
Copy link
Contributor

@elikoga elikoga commented Oct 10, 2020

This should resolve #97 and cleans up the code a tiny bit

@elikoga
Copy link
Contributor Author

elikoga commented Oct 10, 2020

Shoot my branch wasn't clean hold on

Bodigrim
Bodigrim approved these changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@Bodigrim Bodigrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much appreciated.

@Bodigrim Bodigrim requested a review from sjakobi October 12, 2020 18:57
sjakobi
sjakobi approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bodigrim Bodigrim merged commit bf6b921 into haskell:master Oct 12, 2020
@Bodigrim Bodigrim added this to the 0.11.1.0 milestone Oct 12, 2020
@elikoga
Copy link
Contributor Author

elikoga commented Oct 24, 2020

Hey @Bodigrim sorry to bother you but could you add the hacktoberfest-accepted label to this PR?

@Bodigrim
Copy link
Contributor

@elikoga Sure, done.

@Bodigrim Bodigrim mentioned this pull request Oct 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

@Bodigrim Bodigrim Bodigrim approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
0.11.1.0
Development

Successfully merging this pull request may close these issues.

Is hSetBinaryMode required for ByteString I/O?
3 participants
@elikoga @Bodigrim @sjakobi