Skip to content

Commit

Permalink
Attempt to fix CI again (#626)
Browse files Browse the repository at this point in the history
The windows jobs were subtly broken by #613, which caused
the build products to live in bytestring-*/dist-newstyle
instead of dist-newstyle.  This didn't appear to break
immediately because we restored cached stuff in dist-newstyle
including stale executables.  It wasn't until a week of
inactivity caused our cache to expire that the breakage
became appropriately obvious.

I don't really understand what went wrong with the centos job;
I just borrowed the workaround from haskell/text#541.

(cherry picked from commit bf5f5da)
  • Loading branch information
clyring committed Jan 30, 2024
1 parent c8b844f commit f25e33a
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
branches:
- master
- bytestring-0.11
- bytestring-0.12
pull_request: {} # Validate all PRs

defaults:
Expand All @@ -17,7 +18,7 @@ jobs:
fail-fast: true
matrix:
os: [ubuntu-latest]
ghc: ['8.0', '8.2', '8.4', '8.6', '8.8', '8.10', '9.0', '9.2', '9.4', '9.6']
ghc: ['8.0', '8.2', '8.4', '8.6', '8.8', '8.10', '9.0', '9.2', '9.4', '9.6', '9.8']
include:
- os: macOS-latest
ghc: 'latest'
Expand All @@ -33,7 +34,7 @@ jobs:
ghc-version: ${{ matrix.ghc }}
- name: Update cabal package database
run: cabal update
- uses: actions/cache@v2
- uses: actions/cache@v3
name: Cache cabal stuff
with:
path: |
Expand Down Expand Up @@ -75,7 +76,7 @@ jobs:
ghc-version: ${{ matrix.ghc }}
- name: Update cabal package database
run: cabal update
- uses: actions/cache@v2
- uses: actions/cache@v3
name: Cache cabal stuff
with:
path: |
Expand All @@ -97,6 +98,7 @@ jobs:
- name: Run Test
# test broken linking on windows: https://github.com/haskell/bytestring/issues/497
run: |
cd bytestring-*/
$bin = cabal list-bin bytestring-tests
$env:PATH = ''
& "$bin"
Expand Down Expand Up @@ -155,7 +157,7 @@ jobs:
ghc-version: 'latest'
- name: Update cabal package database
run: cabal update
- uses: actions/cache@v2
- uses: actions/cache@v3
name: Cache cabal stuff
with:
path: |
Expand All @@ -174,7 +176,7 @@ jobs:
- name: install deps
run: |
yum install -y gcc gmp gmp-devel make ncurses ncurses-compat-libs xz perl
curl --proto '=https' --tlsv1.2 -sSf https://get-ghcup.haskell.org | BOOTSTRAP_HASKELL_NONINTERACTIVE=1 sh
curl --proto '=https' --tlsv1.2 -sSf https://get-ghcup.haskell.org | BOOTSTRAP_HASKELL_NONINTERACTIVE=1 BOOTSTRAP_HASKELL_GHC_VERSION=9.2.8 sh
- uses: actions/checkout@v3
- name: test
run: |
Expand Down

0 comments on commit f25e33a

Please sign in to comment.