Fixed crash in issue 71 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not really a fan of all the local definitions of (but thanks for diagnosing and fixing the bug!) |
To increase documentation and readability, I added type signatures also to some local definitions. Needs language extension ScopedTypeVariables.
DFA minimization used to crash on tokens of the form c* which produce automata with only accepting states. Considering the empty set of non-accepting states as an equivalence class caused minimization to crash with exception Prelude.head: empty list Now, DFA minimization succeeds. There is still a problem with nullable tokens like c*. Alex produces an infinite token sequence at the end of the input.
Ok, understood. I deleted the patch that does the local
I am yet lacking profiling skills, I am afraid. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ #71 ] Fixed crash in DFAMin
DFA minimization used to crash on tokens of the form c* which produce
automata with only accepting states. Considering the empty set of
non-accepting states as an equivalence class caused minimization to
crash with exception
Prelude.head: empty list
Now, DFA minimization succeeds.
There is still a problem with nullable tokens like c*. Alex produces an
infinite token sequence at the end of the input.