Merge pull request #836 from haskell/hashable-time-0.2.1

Use hashable-time-0.2.1: more tests
haskell · Feb 17, 2021 · 1ee782c · 1ee782c
2 parents 8a0f0b8 + aa938ee
commit 1ee782c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/aeson.cabal b/aeson.cabal
@@ -214,6 +214,7 @@ test-suite aeson-tests
     generic-deriving >= 1.10 && < 1.15,
     ghc-prim >= 0.2,
     hashable >= 1.2.4.0,
+    hashable-time >= 0.2.1 && <0.3,
     scientific,
     strict,
     tagged,
@@ -247,8 +248,6 @@ test-suite aeson-tests
     build-depends: nats >=1 && <1.2,
                    void >=0.7.2 && <0.8
 
-  if impl(ghc >= 7.8)
-    build-depends: hashable-time >= 0.2.0.1 && <0.3
 
   if flag(fast)
     ghc-options: -fno-enable-rewrite-rules

diff --git a/tests/PropertyKeys.hs b/tests/PropertyKeys.hs
@@ -35,11 +35,10 @@ keysTests =
     , testProperty "Float" $ roundTripKey (undefined :: Float)
     , testProperty "Double" $ roundTripKey (undefined :: Double)
     , testProperty "Day" $ roundTripKey (undefined :: Day)
-    -- TODO: needs https://github.com/w3rs/hashable-time/pull/12
-    -- , testProperty "DayOfWeek" $ roundTripKey (undefined :: DayOfWeek)
-    -- , testProperty "Month" $ roundTripKey (undefined :: Month)
-    -- , testProperty "Quarter" $ roundTripKey (undefined :: Quarter)
-    -- , testProperty "QuarterOfYear" $ roundTripKey (undefined :: QuarterOfYear)
+    , testProperty "DayOfWeek" $ roundTripKey (undefined :: DayOfWeek)
+    , testProperty "Month" $ roundTripKey (undefined :: Month)
+    , testProperty "Quarter" $ roundTripKey (undefined :: Quarter)
+    , testProperty "QuarterOfYear" $ roundTripKey (undefined :: QuarterOfYear)
     , testProperty "LocalTime" $ roundTripKey (undefined :: LocalTime)
     , testProperty "TimeOfDay" $ roundTripKey (undefined :: TimeOfDay)
     , testProperty "UTCTime" $ roundTripKey (undefined :: UTCTime)