Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UB on 32 bit platforms #413

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Fix UB on 32 bit platforms #413

merged 2 commits into from
Apr 14, 2022

Conversation

konsumlamm
Copy link
Contributor

Fixes #412. shiftL returns 0 if the shift is >= the bit size.

I checked the resulting core (on a 64 bit platform) and there is no difference, since fullNodeMask is constant folded anyway.

sjakobi
sjakobi approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! :)

@sjakobi sjakobi merged commit 807e3a4 into haskell-unordered-containers:master Apr 14, 2022
@konsumlamm konsumlamm deleted the fix-ub branch April 14, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjakobi sjakobi sjakobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined behaviour on 32-bit platforms
2 participants
@konsumlamm @sjakobi