Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for GHC < 8 #323

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Drop support for GHC < 8 #323

merged 1 commit into from
Nov 1, 2021

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Nov 1, 2021

This prepares u-c for supporting hashable-1.4, as discussed in #318.

This prepares u-c for supporting hashable-1.4, as discussed in
#318.
@sjakobi sjakobi marked this pull request as ready for review November 1, 2021 00:40
@sjakobi sjakobi requested a review from treeowl November 1, 2021 00:40
Copy link
Collaborator

@treeowl treeowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot of good stuff.

@@ -31,56 +31,97 @@ jobs:
matrix:
include:
- compiler: ghc-9.0.1
compilerKind: ghc
compilerVersion: 9.0.1
setup-method: hvr-ppa
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are some hvr-ppa and some ghcup? Is that just what the script did?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I believe haskell-ci preferably installs from hvr-ppa and uses ghcup just for the releases that aren't available from hvr-ppa.

@sjakobi sjakobi merged commit d90ed09 into master Nov 1, 2021
@sjakobi sjakobi deleted the sjakobi/drop-ghc-7 branch November 1, 2021 01:19
sjakobi added a commit that referenced this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants