Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit definitions for stimes, sconcat and mconcat #307

Open
sjakobi opened this issue Mar 10, 2021 · 2 comments
Open

Explicit definitions for stimes, sconcat and mconcat #307

sjakobi opened this issue Mar 10, 2021 · 2 comments
Labels
performance

Comments

@sjakobi
Copy link
Member

sjakobi commented Mar 10, 2021

So far our Semigroup and Monoid instances define only (<>) and mempty. Explicit definitions of stimes, sconcat and mconcat might be able to improve on the defaults.
@sjakobi
Copy link
Member Author

sjakobi commented Mar 29, 2021

For stimes, we can probably simply use stimesIdempotentMonoid.

@konsumlamm konsumlamm mentioned this issue Dec 19, 2021
Merged
@sjakobi
Copy link
Member Author

sjakobi commented Dec 19, 2021

Since the performance implications of using unions to define mconcat are unclear due to #139, I've removed the low-hanging-fruit label.

Apologies for not realizing the connection to #139 earlier! :/

sjakobi pushed a commit that referenced this issue Jan 6, 2022
@konsumlamm
Add definitions for stimes (#340)
6547038 
Also remove unused `LambdaCase` extension.

Resolves part of #307.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjakobi