No long in C-FFI #213
Merged
No long in C-FFI #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
force-pushed
the
no-long
branch
4 times, most recently
from
dc00264 to
239e138
Compare
|
Looks good to me 👍 Test passes and the clash I observed is still fixed. |
|
@mtolly, thanks for checking. I made a release https://hackage.haskell.org/package/hashable-1.3.3.0 with this patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mtolly, thanks for spotting the problem and proposing the fix. I cleaned up it a bit more, could you test that I didn't undo anything on Windows (and that tests pass, the new one in particular)