Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-default-class -> data-default #486

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

9999years
Copy link
Contributor

data-default 0.8 deprecates data-default-class by moving the Default class from Data.Default.Class to Data.Default.

Needs: kazu-yamamoto/crypton-certificate#11
See: commercialhaskell/stackage#7545

data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.
9999years added a commit to MercuryTechnologies/push-notify-apn that referenced this pull request Oct 25, 2024
- In http2, `HeaderList` was replaced with `[Header]`,
  `SettingsHeaderTableSize` was replaced with
  `SettingsTokenHeaderTableSize`.

- data-default 0.8 deprecates data-default-class by moving the `Default`
  class from `Data.Default.Class` to `Data.Default`.

- tls has replaced some default instances with functions and made some
  record constructors private.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to MercuryTechnologies/push-notify-apn that referenced this pull request Oct 25, 2024
- In http2, `HeaderList` was replaced with `[Header]`,
  `SettingsHeaderTableSize` was replaced with
  `SettingsTokenHeaderTableSize`.

- data-default 0.8 deprecates data-default-class by moving the `Default`
  class from `Data.Default.Class` to `Data.Default`.

- tls has replaced some default instances with functions and made some
  record constructors private.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
@larskuhtz
Copy link

It would be nice if Network.TLS could also directly export defaultSupported so that one does not need to depend on data-default at all in order to provide the Supported parameter in TLSSettingsSimple.

At the moment the use of def is the only possibility to create an Supported value.

@9999years
Copy link
Contributor Author

That would be great, but I'm only working on updating the data-default package here. Please open a separate PR if you'd like to change the tls API.

9999years added a commit to 9999years/hs-connection that referenced this pull request Oct 25, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

This is used upstream in `tls`.

See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to 9999years/http-client that referenced this pull request Oct 25, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to 9999years/quic that referenced this pull request Oct 28, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to 9999years/wai that referenced this pull request Oct 28, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to 9999years/wai that referenced this pull request Oct 28, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
9999years added a commit to 9999years/wai that referenced this pull request Oct 28, 2024
data-default 0.8 deprecates data-default-class by moving the `Default`
class from `Data.Default.Class` to `Data.Default`.

See: haskell-grpc-native/http2-client#97
See: kazu-yamamoto/crypton-certificate#11
See: haskell-tls/hs-tls#486
See: commercialhaskell/stackage#7545
@kazu-yamamoto kazu-yamamoto self-requested a review October 29, 2024 01:52
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazu-yamamoto kazu-yamamoto merged commit 65395d7 into haskell-tls:main Oct 29, 2024
@kazu-yamamoto
Copy link
Collaborator

Merged.
Thanks.
My understanding is that new releases are not urgent thanks to data-default-class v2.0.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants