Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly documented default values. #408

Closed
wants to merge 1 commit into from
Closed

explicitly documented default values. #408

wants to merge 1 commit into from

Conversation

kazu-yamamoto
Copy link
Collaborator

Updating documents.

@kazu-yamamoto
Copy link
Collaborator Author

It seems to me that clientUseMaxFragmentLength is not used.

@kazu-yamamoto kazu-yamamoto mentioned this pull request Dec 20, 2019
Closed
5 tasks
@kazu-yamamoto
Copy link
Collaborator Author

@ocheron Ping.

1 similar comment
@kazu-yamamoto
Copy link
Collaborator Author

@ocheron Ping.

ocheron
ocheron approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@ocheron ocheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds sometimes redundancy with the existing comment but will be useful for many parameters.

ocheron added a commit that referenced this pull request Jan 6, 2020
@ocheron
Merge pull request #408 from kazu-yamamoto/doc
750c1a3 
explicitly documented default values.
@ocheron
Copy link
Contributor

ocheron commented Jan 6, 2020

Rebased and merged.

@ocheron ocheron closed this Jan 6, 2020
@kazu-yamamoto kazu-yamamoto deleted the doc branch January 6, 2020 22:47
@kazu-yamamoto
Copy link
Collaborator Author

Thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocheron ocheron ocheron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazu-yamamoto @ocheron