-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch ci to stack and add ci cron job to test hackage breakage #568
Conversation
dcc87bc
to
971f096
Compare
Relates to #565 |
export PATH=$(stack path --bin-path):$PATH | ||
|
||
stack install cabal-install | ||
cabal update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why install cabal-install
via stack
? Why even install stack
in the first place? So that we can install ghc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The install
section of the .travis.yml
also gets executed for cron jobs. (That's where stack
is installed: https://github.com/haskell-servant/servant/pull/568/files#diff-354f30a63fb0907d4ad57269548329e3R18 .) So when executing ci-cron.sh
on travis we already have stack
. But no ghc
and no cabal-install
. So I thought it would be easiest to just use stack
's ghc
and use it to install cabal-install
.
Alternatively we could install ghc
and cabal-install
from hvr's repos, like before. That would have the disadvantage of slowing down the push-triggered builds unnecessarily.
Generally the ci-cron.sh
script is not really how I want it to be. But I think it should be worked on in follow-up PRs. So that we can get the stack CI in place. (And I think it's already better than what we have now.)
I'm okay with or without this change. My opinion has been that |
What we didn't have (before this PR) is CI that checks that the state on I still have to make sure that the cron job succeeds, then I'll merge. |
@soenkehahn fair point. I'm in favor of the change, then. But CI is broken :) . Looks like an issue with |
971f096
to
1b83d30
Compare
This uses the experimental cron job feature by travis: https://docs.travis-ci.com/user/cron-jobs/
It uses
stack
for the normal push-triggered CI.The cron job script still uses
tinc
. We could switch this tostack
once this is fixed: commercialhaskell/stack#2475