Content address method cleanup #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same rename as NixOS/nix@64e599e
This corresponds to NixOS/nix@b51e161 and part of NixOS/nix@ed26b18
|
Now contains #291; very nice! |
Ericson2314
commented
Nov 1, 2024
| ContentAddressMethod_Text -> | ||
| case hashAlgo of | ||
| HashAlgo_SHA256 -> makeTextPath storeDir h $ references_others refs | ||
| _ -> error "unsupported" -- TODO do better; maybe we'll just remove this restriction too? |
There was a problem hiding this comment.
Maybe should make this better :)
sorki
reviewed
Nov 5, 2024
| @@ -1,17 +1,11 @@ | |||
| -- | TODO rename module | |||
There was a problem hiding this comment.
Split into RepairMode.hs and PathFilter.hs? Not sure if worth just for these two.
There was a problem hiding this comment.
I would just revisit such things later :)
I am not even sure PathFilter needs to go in core.
sorki
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some refactors I did in upstream Nix; each commit here links the commits there.