Do not show values eagerly #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to show infinite lists, `ushowWith` would hang until the process runs out of memory, despite `show` working on them. This makes it so they can be shown using `ushow` or `ushowWith` like they can be with `show`.
|
This is failing the test for showing |
|
Thanks for the pull request! |
|
Anyway, I have to update the settings of travis to use the latest LTS Haskells though... Sorry for the inactivity... |
|
@Kaiepi Can you rebase from the latest master? I've updated .travis.yml to test with the newer GHCs. Side note: As I added to README, you might prefer pretty-simple, which subsumes pretty-simple. |
Kaiepi
force-pushed
the
lazy
branch
4 times, most recently
from
3f842a1 to
a6b4023
Compare
igrep
requested changes
Dec 22, 2019
|
Sorry, I'll change my mind. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to show infinite lists,
ushowWithwould hang untilthe process runs out of memory, despite
showworking on them. Thismakes it so they can be shown using
ushoworushowWithlike theycan be with
show.I'm fairly new to Haskell, and I can't be fully certain this behaves the same as before since this is failing a test that's also failing on master (though it passes all of the others), so bear with me.