Add CSS #33
Merged
Add CSS #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
シンプルながらいい感じですね！ トップ（チャンネルの概要を開く前）
トップ（チャンネルの詳細を開いた状態）
チャンネルの詳細
|
mizunashi-mana
force-pushed
the
add-css
branch
from
97bc030 to
2d4e256
Compare
igrep
requested changes
Feb 11, 2020
icon は，メッセージの区切りが分からなくなるので付けました (なので，そこに Slack のアイコンを載せる予定ではありませんでした) |
|
アイコン無しだとこんな感じです．どっちがいいでしょう？ (個人的にはどちらでもいいです)
対比用に同じ場所のアイコンありのも上げときます: |
|
うーん、試しに取り除いてみましたが、個人的には別になくてもいいかなぁ、切れ目を分かりやすくするのであれば、上下のマージンを広めに取るので良いのでは、という印象です。 取り除く前
取り除いた後
|
|
とりあえずなしでお願いします！ |
mizunashi-mana
force-pushed
the
add-css
branch
from
0966993 to
007cfc5
Compare
修正しました |
igrep
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #32 , #19