Allow bytestring-0.11 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2020
emilypi
reviewed
Dec 13, 2020
| let bs = PS fp 0 l | ||
| #endif |
|
@hvr @thoughtpolice ping |
hvr
reviewed
Jan 20, 2021
| @@ -92,7 +93,7 @@ module Crypto.Hash.SHA256 | |||
| import Data.Bits (xor) | |||
| import Data.ByteString (ByteString) | |||
| import qualified Data.ByteString as B | |||
| import Data.ByteString.Internal (ByteString (PS), create, | |||
| import Data.ByteString.Internal (ByteString (..), create, | |||
hvr
reviewed
Jan 20, 2021
| @@ -1,4 +1,5 @@ | |||
| {-# LANGUAGE BangPatterns #-} | |||
| {-# LANGUAGE CPP #-} | |||
hvr
added a commit
that referenced
this pull request
Jan 20, 2021
This avoids the use of CPP where possible; the last remaining CPP use-site could in principle be avoided too by using cabal-level conditional compilation but for now we've just reduced the source-code exposed to the CPP phase to a bare minimum. While at it, also fixup the package description and upgrade to cabal-version:2.0 as there's little reason not to in 2021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important, because
cryptohash-sha256is the last thing blockingCabalfrom embracingbytestring-0.11, as discussed at haskell/cabal#7051. Note that the patch matters only for GHC < 8.0; newer GHCs work fine without any changes except version bump.CC @thoughtpolice, because you are listed as a Hackage maintainer.
Changelog for
bytestring-0.11