Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include benchmarks/*.csv with cabal sdist #117

Merged
merged 1 commit into from
May 31, 2016
Merged

Include benchmarks/*.csv with cabal sdist #117

merged 1 commit into from
May 31, 2016

Conversation

RyanGlScott
Copy link
Contributor

@RyanGlScott RyanGlScott commented May 17, 2016

Currently, the benchmarks fail to run when obtained from Hackage:

Running 1 benchmarks...
Benchmark benchmarks: RUNNING...
benchmarks: benchmarks/presidents.csv: openBinaryFile: does not exist (No such file or directory)
Benchmark benchmarks: ERROR

since cabal sdist doesn't grab the .csv files in the benchmarks directory. Adding them to extra-source-files does the trick.

See also iu-parfunc/sc-haskell#7

@hvr hvr merged commit 545b86d into haskell-hvr:master May 31, 2016
@hvr
Copy link
Collaborator

hvr commented May 31, 2016

thanks!

@bergmark
Copy link
Contributor

Can we get this released, please? Benchmarks are disabled in stackage because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants