Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knownExtensions is missing negative variants #10

Closed
mvdan opened this issue May 22, 2016 · 3 comments
Closed

knownExtensions is missing negative variants #10

mvdan opened this issue May 22, 2016 · 3 comments
Labels
bug
Milestone
0.6

Comments

@mvdan
Copy link
Contributor

mvdan commented May 22, 2016

See gelisam/hawk#157. This also broke backwards compatibility in 0.5.0.
@mvdan mvdan added the bug label May 23, 2016
@mvdan mvdan added this to the 0.6 milestone May 23, 2016
mvdan added a commit that referenced this issue May 24, 2016
@mvdan
generate: include negated extensions
26d8000 
Fixes #10.
@mvdan
Copy link
Contributor Author

mvdan commented May 24, 2016

@gelisam @jcpetruzza care to take a look at the fix above? @gelisam mentioned that some of the extensions (either positive or negative) didn't work on 7.10, so I'm not 100% sure on this.

@gelisam
Copy link
Contributor

gelisam commented May 24, 2016

I confirm that this fix resolves gelisam/hawk#157.

You included NoSafe, NoTrustworthy and NoUnsafe, which don't make much sense, but since this is generated by a script it's probably easier to include them than to not include them, and I don't think including them will cause problems to anyone.

@mvdan
Copy link
Contributor Author

mvdan commented May 24, 2016

Agreed. Thanks for confirming!

@mvdan mvdan closed this as completed in 5211468 May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@gelisam @mvdan