Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include .cabal file in http2-grpc-types package #41

Closed
martyall opened this issue Jul 24, 2020 · 7 comments
Closed

include .cabal file in http2-grpc-types package #41

martyall opened this issue Jul 24, 2020 · 7 comments

Comments

@martyall
Copy link

commercialhaskell/stack#5210

I'm currently getting a warning that future versions of stack will not support building this dependency without a cabal file

@ethercrow
Copy link

With cabal it's even an error, not a warning.

When I have this in a cabal.project:

source-repository-package
  type: git
  location: https://github.com/haskell-grpc-native/http2-grpc-haskell
  tag: 496e92bc967eff02ac3698ba12ba2dfe38bc8b74
  subdir: http2-grpc-types

cabal says

   Cloning into '/home/runner/work/lightstep-haskell/lightstep-haskell/dist-newstyle/src/http2-grp_-decb6024caea4828'...
  HEAD is now at 496e92b Merge pull request #36 from haskell-grpc-native/introduce-bench-tool
  NoCabalFileFound
Error: The process '/opt/cabal/3.0/bin/cabal' failed with exit code 1

@Bargsteen
Copy link

Bargsteen commented Oct 27, 2020

Dealing with the same warning right now, so it would be nice if it were fixed.

@ethercrow
Copy link

@lucasdicioccio please have a look.

@lucasdicioccio
Copy link
Member

Hi, thanks for the highlight; it looks like I don't get emails notifications for this project now that we've moved it to an organization. And suddently I feel ashamed to let this linger for so long. Will have a look very soon

lucasdicioccio added a commit that referenced this issue Nov 18, 2020
@lucasdicioccio
Copy link
Member

Can someone have a quick look at #43 ?

@lucasdicioccio
Copy link
Member

Feel free to reopen and @ mention me 🙏 . I've turned the "Watch" bit to make sure such horrible delays don't occur again (modulo 👶 induced exhaustion).

@Bargsteen
Copy link

Can someone have a quick look at #43 ?

The warning is now gone. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants