Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Rewriting ECC #114

Merged
merged 36 commits into from
Dec 4, 2016
Merged

Rewriting ECC #114

merged 36 commits into from
Dec 4, 2016

Conversation

vincenthz
Copy link
Member

No description provided.

@vincenthz vincenthz mentioned this pull request Dec 1, 2016
-- | Elliptic curve double-scalar multiplication (uses Shamir's trick).
--
-- > pointAddTwoMuls c n1 p1 n2 p2 == pointAdd c (pointMul c n1 p1)
-- > (pointMul c n2 p2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the equation you can remove the argument c.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. done

Now there's no type created by associated type, it just become a routing type class,
however this has a cost, since the associated type are not injective,
requiring more witness for the curve than before.
@vincenthz
Copy link
Member Author

vincenthz commented Dec 2, 2016

@kazu-yamamoto head's up I've changed the API significantly to address some issues. that very likely break any code depending on it, and it may have introduced bugs during the rewrite. let me know if there's anything missing

@vincenthz vincenthz merged commit 07bfa10 into master Dec 4, 2016
@kazu-yamamoto kazu-yamamoto mentioned this pull request May 26, 2017
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants