Fix #182 and #236 #245
Merged
Fix #182 and #236 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add global --run-tests/--no-run-tests/--run-tests-jobs to specify
when we actually run tests (maybe less then what we build!)
- Add steps configuration to constraint sets:
- tests
- run-tests
- benchmarks
- haddock
- these are only booleans for now, if you need more control, make
another constraint set!
RyanGlScott
reviewed
Mar 6, 2019
There was a problem hiding this comment.
Wow! I can't wait to try this out. You're a miracle-worker, @phadej.
RyanGlScott
reviewed
Mar 6, 2019
RyanGlScott
reviewed
Mar 6, 2019
RyanGlScott
approved these changes
Mar 6, 2019
|
I also pushed (hopefully) a fix for #246, if you, @RyanGlScott, mind to check as you are testing this branch |
phadej
commented
Mar 6, 2019
|
I just tried it out on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add global --run-tests/--no-run-tests/--run-tests-jobs to specify
when we actually run tests (maybe less then what we build!)
Add steps configuration to constraint sets:
another constraint set!
cc @RyanGlScott