Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3624: Fix AI worker github build action #5696

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

CiaranMn
Copy link
Member

🌟 What is the purpose of this PR?

In #5691 I amended the AI worker's Dockerfile to accept a new environment variable, but I didn't pass this in as a build-arg in the GitHub action which builds the image.

@github-actions github-actions bot added the area/infra Relates to version control, CI, CD or IaC (area) label Nov 22, 2024
TimDiekmann
TimDiekmann previously approved these changes Nov 22, 2024
@CiaranMn CiaranMn changed the title H-3624: fix AI worker github build action H-3624: Fix AI worker github build action Nov 22, 2024
@CiaranMn CiaranMn self-assigned this Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.93%. Comparing base (47c108f) to head (801897c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5696      +/-   ##
==========================================
+ Coverage   19.55%   21.93%   +2.37%     
==========================================
  Files         522      552      +30     
  Lines       17576    18537     +961     
  Branches     2592     2651      +59     
==========================================
+ Hits         3437     4066     +629     
- Misses      14101    14429     +328     
- Partials       38       42       +4     
Flag Coverage Δ
apps.hash-ai-worker-ts 1.32% <ø> (ø)
apps.hash-api 1.16% <ø> (ø)
blockprotocol.type-system 46.42% <ø> (-0.98%) ⬇️
local.harpc-client 65.69% <ø> (?)
local.hash-backend-utils 8.80% <ø> (ø)
local.hash-graph-sdk 100.00% <ø> (ø)
local.hash-isomorphic-utils 1.04% <ø> (ø)
local.hash-subgraph 24.54% <ø> (ø)
rust.deer 6.66% <ø> (ø)
rust.error-stack 72.51% <ø> (ø)
rust.sarif 87.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$18.2 \mathrm{ms} \pm 210 \mathrm{μs}\left({\color{gray}-0.660 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$17.2 \mathrm{ms} \pm 239 \mathrm{μs}\left({\color{gray}-2.405 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$17.5 \mathrm{ms} \pm 233 \mathrm{μs}\left({\color{gray}-0.796 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$18.7 \mathrm{ms} \pm 249 \mathrm{μs}\left({\color{red}6.20 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$17.7 \mathrm{ms} \pm 207 \mathrm{μs}\left({\color{gray}2.46 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$18.4 \mathrm{ms} \pm 184 \mathrm{μs}\left({\color{red}9.50 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$18.2 \mathrm{ms} \pm 242 \mathrm{μs}\left({\color{red}8.42 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$17.6 \mathrm{ms} \pm 179 \mathrm{μs}\left({\color{gray}2.87 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$18.5 \mathrm{ms} \pm 156 \mathrm{μs}\left({\color{gray}-0.840 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$72.1 \mathrm{ms} \pm 434 \mathrm{μs}\left({\color{gray}-0.455 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$43.1 \mathrm{ms} \pm 211 \mathrm{μs}\left({\color{gray}1.89 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$62.3 \mathrm{ms} \pm 353 \mathrm{μs}\left({\color{gray}0.840 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$46.8 \mathrm{ms} \pm 196 \mathrm{μs}\left({\color{gray}1.39 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$52.8 \mathrm{ms} \pm 215 \mathrm{μs}\left({\color{gray}0.656 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$57.7 \mathrm{ms} \pm 429 \mathrm{μs}\left({\color{gray}0.892 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$113 \mathrm{ms} \pm 466 \mathrm{μs}\left({\color{gray}-1.931 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$45.7 \mathrm{ms} \pm 218 \mathrm{μs}\left({\color{gray}0.012 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$104 \mathrm{ms} \pm 294 \mathrm{μs}\left({\color{gray}-0.208 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$85.4 \mathrm{ms} \pm 370 \mathrm{μs}\left({\color{gray}-1.238 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$94.2 \mathrm{ms} \pm 577 \mathrm{μs}\left({\color{gray}-0.663 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$99.1 \mathrm{ms} \pm 498 \mathrm{μs}\left({\color{gray}0.195 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.43 \mathrm{ms} \pm 5.73 \mathrm{μs}\left({\color{gray}1.95 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$564 \mathrm{ms} \pm 4.82 \mathrm{ms}\left({\color{red}109 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$26.7 \mathrm{ms} \pm 430 \mathrm{μs}\left({\color{gray}3.06 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.7 \mathrm{ms} \pm 116 \mathrm{μs}\left({\color{gray}1.09 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$53.1 \mathrm{ms} \pm 295 \mathrm{μs}\left({\color{gray}1.88 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$73.6 \mathrm{ms} \pm 420 \mathrm{μs}\left({\color{gray}-2.262 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$1.92 \mathrm{ms} \pm 16.0 \mathrm{μs}\left({\color{gray}-1.575 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.08 \mathrm{ms} \pm 9.20 \mathrm{μs}\left({\color{gray}-0.411 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.95 \mathrm{ms} \pm 8.03 \mathrm{μs}\left({\color{gray}-1.516 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.88 \mathrm{ms} \pm 11.1 \mathrm{μs}\left({\color{gray}-0.184 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$14.4 \mathrm{ms} \pm 63.0 \mathrm{μs}\left({\color{gray}-0.325 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$4.39 \mathrm{ms} \pm 28.4 \mathrm{μs}\left({\color{lightgreen}-22.399 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.94 \mathrm{ms} \pm 12.8 \mathrm{μs}\left({\color{gray}-2.517 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.93 \mathrm{ms} \pm 11.4 \mathrm{μs}\left({\color{gray}-0.610 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.17 \mathrm{ms} \pm 12.0 \mathrm{μs}\left({\color{gray}0.068 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.44 \mathrm{ms} \pm 23.9 \mathrm{μs}\left({\color{red}21.2 \mathrm{\%}}\right) $$ Flame Graph

@CiaranMn CiaranMn added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit d50031f Nov 22, 2024
165 of 166 checks passed
@CiaranMn CiaranMn deleted the cm/fix-docker-build-action branch November 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Relates to version control, CI, CD or IaC (area)
Development

Successfully merging this pull request may close these issues.

2 participants