Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3617: harpc: Implement TypeScript wire-protocol codec #5686

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

indietyp
Copy link
Member

🌟 What is the purpose of this PR?

Implement the wire-protocol streaming interface (similar to the one we have in hash_codec::harpc.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@github-actions github-actions bot added area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team area/tests New or updated tests labels Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.83%. Comparing base (8bd2f22) to head (c824b17).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5686   +/-   ##
=======================================
  Coverage   19.83%   19.83%           
=======================================
  Files         515      515           
  Lines       17327    17327           
  Branches     2548     2548           
=======================================
  Hits         3437     3437           
  Misses      13852    13852           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@indietyp indietyp force-pushed the bm/harpc/typescript-wire-test branch from ff5472c to 9232d89 Compare November 21, 2024 17:08
@vilkinsons vilkinsons changed the title harpc: Typescript implement wire-protocol codec H-3617: harpc: Implement TypeScript wire-protocol codec Nov 21, 2024
CiaranMn
CiaranMn previously approved these changes Nov 21, 2024
@indietyp indietyp added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 74098e6 Nov 22, 2024
34 checks passed
@indietyp indietyp deleted the bm/harpc/typescript-codec branch November 22, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs Relates to first-party libraries/crates/packages (area) area/tests New or updated tests type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

2 participants