-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-3617: harpc
: Implement TypeScript wire-protocol
codec
#5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/libs
Relates to first-party libraries/crates/packages (area)
type/eng > backend
Owned by the @backend team
area/tests
New or updated tests
labels
Nov 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5686 +/- ##
=======================================
Coverage 19.83% 19.83%
=======================================
Files 515 515
Lines 17327 17327
Branches 2548 2548
=======================================
Hits 3437 3437
Misses 13852 13852
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
indietyp
force-pushed
the
bm/harpc/typescript-wire-test
branch
from
November 21, 2024 17:08
ff5472c
to
9232d89
Compare
indietyp
force-pushed
the
bm/harpc/typescript-codec
branch
from
November 21, 2024 17:10
2e3e71a
to
cc0a90c
Compare
vilkinsons
changed the title
H-3617: Nov 21, 2024
harpc
: Typescript implement wire-protocol codecharpc
: Implement TypeScript wire-protocol
codec
CiaranMn
previously approved these changes
Nov 21, 2024
indietyp
force-pushed
the
bm/harpc/typescript-codec
branch
from
November 21, 2024 19:04
bf88b27
to
a0b1322
Compare
indietyp
force-pushed
the
bm/harpc/typescript-codec
branch
from
November 21, 2024 20:58
a0b1322
to
c824b17
Compare
CiaranMn
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/libs
Relates to first-party libraries/crates/packages (area)
area/tests
New or updated tests
type/eng > backend
Owned by the @backend team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Implement the wire-protocol streaming interface (similar to the one we have in
hash_codec::harpc
.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR: