Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H-3614: Introduce chonky PDF Embeddings #5673

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

H-3614: Introduce chonky PDF Embeddings #5673

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08857d5
Add Multi-Modal Embeddings
JesusFileto Nov 17, 2024
5359c42
Implement Preliminary Embedding Model
JesusFileto Nov 18, 2024
3aaf4f7
Prevent Cold HuggingFace Models from giving testing errors
JesusFileto Nov 26, 2024
5d9d336
Begin Implementing Async through Reqwest
JesusFileto Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 66 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,12 @@ ariadne = { version = "=0.5.0", default-features = false }
aws-types = { version = "=1.3.3", default-features = false }
axum = { version = "0.7.5" }
axum-core = { version = "0.4.3" }
base64 = { version = "=0.22.1" }
bumpalo = { version = "=3.16.0", default-features = false }
bytes = { version = "1.6.0" }
clap_builder = { version = "=4.5.21", default-features = false, features = ["std"] }
criterion = { version = "=0.5.1" }
curl = { version = "=0.4.47" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use reqwest instead. It's already configured in the root-manifest. You probably want to enable the json feature so we don't need to convert JSON to string first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok have pushed out some changes that do this, but unable to solve the tokio linter errors that occur from moves during the await function.

deadpool = { version = "=0.12.1", default-features = false }
deadpool-postgres = { version = "=0.14.0", default-features = false }
ecow = { version = "=0.2.3", default-features = false }
Expand Down
5 changes: 5 additions & 0 deletions libs/chonky/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,13 @@ edition.workspace = true
error-stack = { workspace = true, public = true }

# Public third-party dependencies
base64 = { workspace = true }
curl = { workspace = true }
image = { workspace = true, public = true, features = ["png", "bmp"] }
num-traits = { workspace = true }
pdfium-render = { workspace = true, public = true }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }

# Private workspace dependencies

Expand Down
Loading
Loading