-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H-2362: Support converting BaseUrl
to/from Postgres
#4148
Merged
TimDiekmann
merged 6 commits into
main
from
t/h-2362-support-converting-baseurl-tofrom-postgres
Mar 12, 2024
Merged
H-2362: Support converting BaseUrl
to/from Postgres
#4148
TimDiekmann
merged 6 commits into
main
from
t/h-2362-support-converting-baseurl-tofrom-postgres
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/deps
Relates to third-party dependencies (area)
area/apps > hash*
Affects HASH (a `hash-*` app)
area/libs
Relates to first-party libraries/crates/packages (area)
type/eng > backend
Owned by the @backend team
area/tests
New or updated tests
area/tests > integration
New or updated integration tests
area/apps
area/apps > hash-graph
labels
Mar 11, 2024
CiaranMn
previously approved these changes
Mar 12, 2024
Base automatically changed from
t/h-2205-support-multi-type-entities-in-the-graph
to
main
March 12, 2024 13:21
TimDiekmann
force-pushed
the
t/h-2362-support-converting-baseurl-tofrom-postgres
branch
from
March 12, 2024 13:35
ec62d2d
to
c7e9604
Compare
3 tasks
CiaranMn
approved these changes
Mar 12, 2024
TimDiekmann
deleted the
t/h-2362-support-converting-baseurl-tofrom-postgres
branch
March 12, 2024 17:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/apps > hash*
Affects HASH (a `hash-*` app)
area/apps > hash-graph
area/apps
area/deps
Relates to third-party dependencies (area)
area/libs
Relates to first-party libraries/crates/packages (area)
area/tests > integration
New or updated integration tests
area/tests
New or updated tests
type/eng > backend
Owned by the @backend team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
To allow converting a full
VersionedUrl
to/from Postgres the underlyingBaseUrl
has to be convertible. This allows a lot of simplification in queries as the types don't need to be converted to an intermediate string.🚫 Blocked by
🔍 What does this change?
OntologyTypeVersion
to type system crateBaseUrl
andVersionedUrl
BaseUrl
directly to convert from/to PostgresPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR: