Clash: cannot nest twice even when key is Clash class

[bartoszkopinski]

Hello,

In the example found in README:

https://github.com/intridea/hashie#clash

The suggestion to access one of the nested hashes is by using bang methods:

c = Hashie::Clash.new
c.where!.nested(10)._end!
# => {:where=>{:nested=>10}}

However, a second attempt to do the same results in ChainError exception:

c = Hashie::Clash.new
c.where!.nested(10)._end!
c.where!.another(10)._end!
Hashie::Clash::ChainError: Tried to chain into a non-hash key.

Of course this is a naive example, as the issue trying to solve is merge nested elements:

c = Hashie::Clash.new
c.where(location: { near: [1, 2] })
# => {:where=>{:location=>{:near=>[1, 2]}}}
c.where(location: { distance: "100mi" })
# => {:where=>{:location=>{:distance=>"100mi"}}}

There is no way, without using the nested (bang) methods to workaround this limitation.

Looking at the logic of the code:

https://github.com/intridea/hashie/blob/59069f13ea067a319584a56674cc02de887b999f/lib/hashie/clash.rb#L73-L76

Seems that one scenario is missing, which is the case when self[key] is already a Clash instance.

Wanted to confirm if is the desired behavior, there are alternatives or a pull request might be in order 😁

Thank you!

[dblock]

Right on @luislavena, you're totally right.

[dblock]

This just needs a CHANGELOG entry, please (via --amend), and I'll merge, please?

[luislavena]

@dblock want me to provide the changelog item?

btw, thanks for working on a fix for this!

[dblock]

Yes, something I can merge.

[dblock]

Bump @luislavena

[luislavena]

@dblock just to be clear: take your change, change the changelog and then send as a pull request?

[dblock]

@luislavena I just want you to finish this PR! It needs a CHANGELOG entry.

[luislavena]

Hello @dblock

Really sorry to upset you. I do understand you want to get this change merged, however while I originally reported this issue, wasn't me who contributed the change (or turned the issue into a pull request)

The user that provided the change is @bartoszkopinski and the changes were in his fork.

To be honest is the first time that a reporter of the issue is being asked to provide the CHANGELOG entry description, even when wasn't me who provided the patch.

Anyway, I went ahead and forked, pulled the changes from @bartoszkopinski branch (bk-240-clash-fixes) and amend into this commit:

master...luislavena:bk-240-clash-fixes

Not sure I should be submitting another pull request for the same and also don't want to take credit for the change made by @bartoszkopinski .

Please let me know if I missed something.

Thank you.

[dblock]

My bad @luislavena I didn't notice that :)

[dblock]

Just make a PR with that? You can amend on behalf of the original author.

[luislavena]

@dblock done, see #321, rebased.

[dblock]

Closed via #321.