This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Upgrade bolt to bbolt #1631
Merged
Upgrade bolt to bbolt #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1537
mitchellh
approved these changes
Jun 9, 2021
mitchellh
reviewed
Jun 9, 2021
.changelog/1631.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:improvement | |||
| core: Upgrade from unmaintained `boltdb/bolt` to `etcd-io/bbolt` | |||
There was a problem hiding this comment.
I almost feel like a changelog entry isn't even required for this change. I usually avoid non-user-impacting changes from the CL.
This reverts commit aff9cf4.
izaaklauer
added
the
pr/no-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boltdb is no longer maintained, and causes intermittent test failures. Bolt also causes a runtime crash when attempting to run
go testwith the-raceflag.Etcd's bbolt is api-compatible with boltdb, and it's database file appears to be structurally compatible too. I've tested reading builds, config, deployments, jobs, projects, status reports, and releases created by
bolt, and writing and reading new values withbbolt, and it all works as expected.There are no documented structural incompatibilities or related issues that I've found, and there are examples of other projects doing this successfully.
Note that raft-boltdb chose to perform this upgrade by migrating the database file, but moreso out of an abundance of caution than to work around any specific issues.
Closes #1537