Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental Prefill Required Fields feature #799

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Sep 29, 2021

radeksimko
radeksimko previously approved these changes Sep 30, 2021
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that this would not require us to delay releasing this option as part of next extension version? LS will actually raise warnings when unknown config options are passed.

Unless it already works that way I think we could avoid sending the option there entirely if it's (default) false, so that it only affects people who explicitly opt-in and do so too early, before upgrading LS.

@jpogran
Copy link
Contributor Author

jpogran commented Sep 30, 2021

Adding to the existing terraform-ls.experimentalFeatures won't send anything automatically because the default value for terraform-ls.experimentalFeatures is undefined. Only when the user adds the property to their config would it send something.

With that in mind, I think this is safe to release at the same time as the LS

@jpogran jpogran self-assigned this Oct 4, 2021
@jpogran jpogran added the enhancement New feature or request label Oct 4, 2021
This adds a new experimental setting for prefilling required attributes as blocks are completed from intellisense. For example, completing a resource provider will fill in the required attributes automatically.
@jpogran jpogran force-pushed the prefill-required-block branch from 091b633 to c0369f1 Compare October 6, 2021 15:37
@jpogran jpogran changed the title Prefill Required Attributes Add experimental Prefill Required Fields feature Oct 6, 2021
@jpogran jpogran marked this pull request as ready for review October 6, 2021 17:40
@jpogran jpogran requested a review from radeksimko October 6, 2021 17:40
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants