Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README content #73

Merged
merged 4 commits into from
May 13, 2022
Merged

Update README content #73

merged 4 commits into from
May 13, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented May 5, 2022

This adds more detail to the README and works on standardizing naming.

This changed all references to the extension as HCL Extension for Visual Studio Code to comply with https://code.visualstudio.com/brand. It also added boilerplate info from the HCL repo to explain what it is we are actually highlighting.

@jpogran jpogran added the enhancement New feature or request label May 5, 2022
@jpogran jpogran self-assigned this May 5, 2022
@jpogran jpogran added this to the 0.1.0 milestone May 5, 2022
@jpogran jpogran marked this pull request as ready for review May 5, 2022 16:39
@jpogran jpogran requested a review from a team as a code owner May 5, 2022 16:39
README.md Outdated Show resolved Hide resolved
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from some in-line suggestions.

## Credits

- [William Holroyd](https://github.com/wholroyd) for past maintenance of [`wholroyd.HCL`](https://marketplace.visualstudio.com/items?itemName=wholroyd.HCL) VS Code extension and for agreeing to the extension namespace transfer to make the transition conflict-less and easy for existing users
- We thank [William Holroyd](https://github.com/wholroyd) for creation and past maintenance of [`wholroyd.HCL`](https://marketplace.visualstudio.com/items?itemName=wholroyd.HCL) VS Code extension and for agreeing to the extension namespace transfer to make the transition conflict-less and easy for existing users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jpogran and others added 4 commits May 13, 2022 10:44
This adds more detail to the README and works on standardizing naming.

This changed all references to the extension as `HCL Extension for Visual Studio Code` to comply with https://code.visualstudio.com/brand. It also added boilerplate info from the HCL repo to explain what it is we are actually highlighting.
@jpogran jpogran merged commit 269c982 into main May 13, 2022
@jpogran jpogran deleted the readme-update branch May 13, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants