Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: fix product detection #176

Merged
merged 1 commit into from
Nov 23, 2022
Merged

telemetry: fix product detection #176

merged 1 commit into from
Nov 23, 2022

Conversation

radeksimko
Copy link
Member

As the documentation attached to the unhelpful field name is trying to explain

Screenshot 2022-11-23 at 12 31 08

the fileName is not actually file name but file path.

This is why prior to this patch we would never detect certain products/languages (Waypoint, Sentinel, Terraform lock, or Terragrunt).

This PR is fixing that.

@radeksimko radeksimko added the bug Something isn't working label Nov 23, 2022
@radeksimko radeksimko requested a review from a team as a code owner November 23, 2022 12:45
Copy link

@gregone gregone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@radeksimko radeksimko merged commit 35f9b3e into main Nov 23, 2022
@radeksimko radeksimko deleted the b-fix-telemetry branch November 23, 2022 13:09
@dbanck dbanck mentioned this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants