Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly handle TLS config when ssl=true or tls=true connection string option set. #9519

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

cyrus-mc
Copy link
Contributor

fix for #9509

Merge writeOpts and authOpts after call too ApplyURI.

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 17, 2020

CLA assistant check
All committers have signed the CLA.

@cyrus-mc
Copy link
Contributor Author

Build is failing with error about using internal module. This PR doesn't touch any of that (it is a simple one line change) so not sure how this error is being caused.

@cyrus-mc
Copy link
Contributor Author

@ncabatoff Merged in latest master changes that fixed build. This PR is ready to go. I am using a locally build Vault, containing this fix, without issue.

@ncabatoff ncabatoff merged commit 9546f18 into hashicorp:master Jul 22, 2020
@ncabatoff
Copy link
Collaborator

Thanks @cyrus-mc!

@pbar1
Copy link
Contributor

pbar1 commented Feb 23, 2021

Hey, FYI - this change seemed to break our Mongo secret engine upon upgrading Vault from 1.5 -> 1.6. When setting up the provider, we use client TLS as well as the username/password authentication via SCRAM-SHA-256. Due to the order in which this change merges config, if client TLS configuration is passed, the MongoDB x.509 auth mechanism will always win; this renders other auth mechanisms unusable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants