Validate physical CockroachDB table config value before using it #9191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Checks the table name against the rules specified in the CockroachDB docs
Valarissa
reviewed
Jun 11, 2020
| "YEAR": true, | ||
| "ZONE": true, | ||
| } | ||
| ) |
catsby
added a commit
that referenced
this pull request
Jun 15, 2020
* master: (36 commits) Minor transform docs rewording (#9223) Validate physical CockroachDB table config value before using it (#9191) Validate physical MySQL database and table config values before using them (#9189) add disable_iss_validation option to k8s auth docs (#9142) fix: configutil redeclared as imported package name (#9211) Integrate password policies into RabbitMQ secret engine (#9143) Clarify cache setting. (#9204) Test pre-1.4 seal migration (#9085) Simple typos (#9119) Update contribution guidelines changelog++ Add ssh signing algorithm as a role option. (#9096) replacing "a key usage mode" as it is confusing (#9194) changelog++ fix: invalidate cached clients after a config change in the aws secrets backend (#9186) website: remove whitepaper link from subnav (#9190) changelog++ Improving transit batch encrypt and decrypt latencies (#8775) changelog++ AWS: Add iam_groups parameter to role create/update (#8811) ...
andaley
pushed a commit
that referenced
this pull request
Jul 17, 2020
* Validate table name (and database if specified) prior to using it in SQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding validation to the CockroachDB physical backend's table config value.
From the CockroachDB docs
The rules implemented here are a bit more restricted than what is listed on the docs for ease of implementation. Also explicitly rejecting backticks, single quotes, and double quotes to prevent problems when using it in SQL queries.