Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ui/summary dashboard #9079
Ui/summary dashboard #9079
Changes from 28 commits
befb629
05e52ca
a912311
01fd5b2
c890cdc
0121803
a1dd392
1cd1fc8
e71f023
536a9a8
ee43fcb
a0f4fca
59e29e3
68f34fb
59df88c
fe2ebc6
e00460f
ca03f9f
716de2e
38846bc
fc17ec7
b81dce9
eefc064
3dff903
1b42499
bb2b4c8
df1464e
d092a01
901ad25
2f58e27
54d578a
74ddb0e
38e67d4
e29493b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to check if the dr mode is also primary? In that case this line should be
return drMode === 'primary' && performanceMode === 'primary'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! This one was a slippery one to catch because we only compute this property when the summary dashboard shows, which only happens when both are a primary so by default it was correctly returning true, but not because drMode was a primary, but because peroformanceMode always was. I'll tag @noelledaley as I believe she wrote this.