Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject requests read and write requests to cubbyhole with an empty path #8971

Merged
merged 3 commits into from
May 11, 2020
Merged

Reject requests read and write requests to cubbyhole with an empty path #8971

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79583c1
Reject requests read, write, and delete requests to cubbyhole with an…
sgmiller May 11, 2020
4e16030
Reject requests read, write, and delete requests to cubbyhole with an…
sgmiller May 11, 2020
bf13fdf
Allow deletes, to clean up accidentally past writes of the empty path
sgmiller May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions vault/logical_cubbyhole.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ func (b *CubbyholeBackend) handleRead(ctx context.Context, req *logical.Request,

path := data.Get("path").(string)

if path == "" {
return nil, fmt.Errorf("missing path")
}

// Read the path
out, err := req.Storage.Get(ctx, req.ClientToken+"/"+path)
if err != nil {
Expand Down Expand Up @@ -147,6 +151,10 @@ func (b *CubbyholeBackend) handleWrite(ctx context.Context, req *logical.Request

path := data.Get("path").(string)

if path == "" {
return nil, fmt.Errorf("missing path")
}

// JSON encode the data
buf, err := json.Marshal(req.Data)
if err != nil {
Expand Down