Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last changes #8346

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Last changes #8346

merged 1 commit into from
Feb 13, 2020

Conversation

tyrannosaurus-becks
Copy link
Contributor

This PR:

  • Uses the uuid library we've already used a lot in Vault to avoid a new dependency.
  • Adds a tiny bit more commentary.
  • Just a couple nit-picky changes like not having a space before the defer statements. This is basically a somewhat irrational tick I have because I worry that down the road others will add more code there and further separate the defer.

@tyrannosaurus-becks tyrannosaurus-becks force-pushed the malnick/redshift-last-changes branch from 0356c78 to 011faae Compare February 13, 2020 17:33
@malnick malnick merged commit 7ec264d into malnick/redshift Feb 13, 2020
@tyrannosaurus-becks tyrannosaurus-becks deleted the malnick/redshift-last-changes branch February 13, 2020 17:34
malnick pushed a commit that referenced this pull request Feb 13, 2020
@tyrannosaurus-becks @malnick
feat: set middlewear type name for better metrics naming (#8346)
b95f8e3
malnick added a commit that referenced this pull request Feb 13, 2020
@malnick @tyrannosaurus-becks
Add redshift database plugin (#8299)
942dd1e 
* feat: add redshift database plugin

* build: update vendored libraries

* docs: add reference doc for redshift variant of the database secrets engine

* feat: set middlewear type name for better metrics naming (#8346)

Co-authored-by: Becca Petrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyrannosaurus-becks @malnick