WIP: PKI: Unset the SignatureAlgorithm for cross-signing of different key types #8157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng of different key types
jefferai
reviewed
Feb 10, 2020
| @@ -429,6 +429,10 @@ func (b *backend) pathCASignSelfIssued(ctx context.Context, req *logical.Request | |||
| cert.CRLDistributionPoints = urls.CRLDistributionPoints | |||
| cert.OCSPServer = urls.OCSPServers | |||
|
|
|||
| // clear out the signature algorithm. This allows cross-signing certificates | |||
| // of different key types, at the cost of verifying the algorithm used. | |||
| cert.SignatureAlgorithm = x509.UnknownSignatureAlgorithm | |||
There was a problem hiding this comment.
Wouldn't it be a better idea to look at the public key from the certificate to be signed and set appropriately?
|
Hello from the Consul team! What is needed to merge this PR? Does this approach seem reasonable to the vault team? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP / Draft: Do not merge
This implements the request from #7709 by unsetting the received certificates signing algorithm, allowing cross-signing of different key types (ex: RSA cross-signs and EC type cert). The obvious trade-off is that the
x509.CreateCertificatefunction will no longer verify the signing algorithms match, so this feels like something that should be gated behind an additional flag or required parameter, so that this behavior is opt-in as opposed to performing this on every cert.I'd like feedback on some items:
skip-type-verify