Update framework forwarding logic to handle nil system views

sdk/framework/backend.go

@@ -228,15 +228,17 @@ func (b *Backend) HandleRequest(ctx context.Context, req *logical.Request) (*log
 		if op, ok := path.Operations[req.Operation]; ok {
 
 			// Check whether this operation should be forwarded
-			replState := b.System().ReplicationState()
-			props := op.Properties()
+			if sysView := b.System(); sysView != nil {
+				replState := sysView.ReplicationState()
+				props := op.Properties()
 
-			if props.ForwardPerformanceStandby && replState.HasState(consts.ReplicationPerformanceStandby) {
-				return nil, logical.ErrReadOnly
-			}
+				if props.ForwardPerformanceStandby && replState.HasState(consts.ReplicationPerformanceStandby) {
+					return nil, logical.ErrReadOnly
+				}
 
-			if props.ForwardPerformanceSecondary && !b.System().LocalMount() && replState.HasState(consts.ReplicationPerformanceSecondary) {
-				return nil, logical.ErrReadOnly
+				if props.ForwardPerformanceSecondary && !sysView.LocalMount() && replState.HasState(consts.ReplicationPerformanceSecondary) {
+					return nil, logical.ErrReadOnly
+				}
 			}
 
 			callback = op.Handler()

sdk/framework/backend_test.go

@@ -124,6 +124,7 @@ func TestBackendHandleRequest_Forwarding(t *testing.T) {
 		isStandby    bool
 		isSecondary  bool
 		expectFwd    bool
+		nilSysView   bool
 	}{
 		"no forward": {
 			expectFwd: false,
@@ -159,6 +160,10 @@ func TestBackendHandleRequest_Forwarding(t *testing.T) {
 			isSecondary: true,
 			expectFwd:   false,
 		},
+		"nil system view": {
+			nilSysView: true,
+			expectFwd:  false,
+		},
 	}
 
 	for name, test := range tests {
@@ -193,6 +198,10 @@ func TestBackendHandleRequest_Forwarding(t *testing.T) {
 				},
 			}
 
+			if test.nilSysView {
+				b.system = nil
+			}
+
 			_, err := b.HandleRequest(context.Background(), &logical.Request{
 				Operation: logical.ReadOperation,
 				Path:      "foo",