Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI update headless chrome flags to fix 'yarn run test:oss' #8035

Merged
merged 5 commits into from
Dec 18, 2019
Merged

UI update headless chrome flags to fix 'yarn run test:oss' #8035

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b05225
UI update headless chrome flags to fix ember/chrome crash in test
xntrik Dec 17, 2019
2434b43
UI update references from test-oss to test:oss
xntrik Dec 17, 2019
87ba8ac
UI removed disable-gpu flag from headless Chrome
xntrik Dec 18, 2019
c691177
UI and also remove the comment
xntrik Dec 18, 2019
5071223
Merge branch 'master' into cfrichot/headless-ember-test-fix
Monkeychip Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ test-ember:
@echo "--> Installing JavaScript assets"
@cd ui && yarn --ignore-optional
@echo "--> Running ember tests"
@cd ui && yarn run test-oss
@cd ui && yarn run test:oss

ember-ci-test: # Deprecated, to be removed soon.
@echo "ember-ci-test is deprecated in favour of test-ui-browserstack"
Expand Down
4 changes: 2 additions & 2 deletions ui/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ Running tests will spin up a Vault dev server on port 9200 via a
pretest script that testem (the test runner) executes. All of the
acceptance tests then run, proxing requests back to that server.

- `yarn run test-oss`
- `yarn run test-oss -s` to keep the test server running after the initial run.
- `yarn run test:oss`
- `yarn run test:oss -s` to keep the test server running after the initial run.
- `yarn run test -f="policies"` to filter the tests that are run. `-f` gets passed into
[QUnit's `filter` config](https://api.qunitjs.com/config/QUnit.config#qunitconfigfilter-string--default-undefined)
- `yarn run test:browserstack` to run the kv acceptance tests in Browserstack
Expand Down
3 changes: 2 additions & 1 deletion ui/testem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ const config = {
// --no-sandbox is needed when running Chrome inside a container
process.env.CI ? '--no-sandbox' : null,
'--headless',
'--disable-gpu',
// as per https://github.com/ember-cli/ember-cli/pull/8774
xntrik marked this conversation as resolved.
Show resolved Hide resolved
//'--disable-gpu',
'--disable-software-rasterizer',
'--mute-audio',
'--remote-debugging-port=0',
Expand Down