-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an sts_region parameter to the AWS auth engine's client config #7922
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fd058e4
add sts_region param to aws auth client config
tyrannosaurus-becks e6739b3
break if region unfound
tyrannosaurus-becks 8eec903
increase test coverage
tyrannosaurus-becks cd137f8
Merge branch 'master' into issue-7418
tyrannosaurus-becks 1dbb501
perform region override in client.go
tyrannosaurus-becks 7b88882
only check STSEndpoint once
tyrannosaurus-becks 760aac2
Merge branch 'master' into issue-7418
tyrannosaurus-becks 66a08b8
changes from feedback
tyrannosaurus-becks db4f297
automate test to run if values given
tyrannosaurus-becks 03ade82
fix imports
tyrannosaurus-becks 6801ae7
Merge branch 'master' into issue-7418
tyrannosaurus-becks e23d897
improve explanation regarding role arn
tyrannosaurus-becks 13dfdc1
use shared testing var
tyrannosaurus-becks fb406be
Merge branch 'issue-7418' of https://github.com/hashicorp/vault into …
tyrannosaurus-becks 458a418
fail if acc tests and aws creds unset
tyrannosaurus-becks 14635c1
Merge branch 'master' into issue-7418
tyrannosaurus-becks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestBackendAcc_LoginWithInstanceIdentityDocAndWhitelistIdentity
andTestBackendAcc_LoginWithCallerIdentity
will actually override theAWS_*
environment variables withTEST_AWS_*
-- this creates a little bit of inconsistency. Maybe extract that overriding logic into a common function (e.g.,setupTestCreds
) to also be called here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, that has the potential to expand the scope of this PR to tuning tests. For instance, I'm looking at
TestBackendAcc_LoginWithInstanceIdentityDocAndWhitelistIdentity
and I'm noticing that here, the code verifies that the env vars aren't empty and subsequently uses them, but here it checks for an impossible condition and fails if it's found. I'm thinking it might make more sense to leave this test as-is because it's consistent with code already in Vault, and to make a separate ticket to circle back and resolve test inconsistencies.