Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an sts_region parameter to the AWS auth engine's client config #7922
Add an sts_region parameter to the AWS auth engine's client config #7922
Changes from 11 commits
fd058e4
e6739b3
8eec903
cd137f8
1dbb501
7b88882
760aac2
66a08b8
db4f297
03ade82
6801ae7
e23d897
13dfdc1
fb406be
458a418
14635c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestBackendAcc_LoginWithInstanceIdentityDocAndWhitelistIdentity
andTestBackendAcc_LoginWithCallerIdentity
will actually override theAWS_*
environment variables withTEST_AWS_*
-- this creates a little bit of inconsistency. Maybe extract that overriding logic into a common function (e.g.,setupTestCreds
) to also be called here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, that has the potential to expand the scope of this PR to tuning tests. For instance, I'm looking at
TestBackendAcc_LoginWithInstanceIdentityDocAndWhitelistIdentity
and I'm noticing that here, the code verifies that the env vars aren't empty and subsequently uses them, but here it checks for an impossible condition and fails if it's found. I'm thinking it might make more sense to leave this test as-is because it's consistent with code already in Vault, and to make a separate ticket to circle back and resolve test inconsistencies.