Backport 1.3.x: Agent Template: check rendering to match expectations (#7899) #7918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add regression test for #7883 * Add logic to count render events and match them to expected * remove the WAIT label and make some changes to remove the break statements * change the 'randomness' of the templateContents test helper method
briankassouf
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #7899 to the release/1.3.x branch
add regression test for Vault Agent Template not rendering all templates #7883
Add logic to count render events and match them to expected
remove the WAIT label and make some changes to remove the break statements
change the 'randomness' of the templateContents test helper method