Ui/dismiss status menu click #7337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaley
pushed a commit
that referenced
this pull request
Aug 20, 2019
* dismiss status menu on click instead of hover * allow redirect on 204
Closed
andaley
pushed a commit
that referenced
this pull request
Aug 20, 2019
* dismiss status menu on click instead of hover * allow redirect on 204
andaley
pushed a commit
that referenced
this pull request
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dismiss Status Menu on Click
This PR dismisses the Status Menu by clicking outside of the menu instead of when hovering off of it. This new behavior fixes the case where users couldn't revoke a token because the menu would disappear before they had the chance to click on the the 'revoke' button.