clear namespaces on logout and properly render nested namespaces in the namepace picker #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirish
force-pushed
the
b-clear-namespaces
branch
from
bab5f35 to
37231db
Compare
madalynrose
reviewed
Jul 26, 2019
| this.get('controlGroup').deleteTokens(); | ||
| this.get('console').set('isOpen', false); | ||
| this.get('console').clearLog(true); | ||
| this.auth.deleteCurrentToken(); |
madalynrose
reviewed
Jul 26, 2019
| <LinkTo | ||
| @params={{array "vault.cluster.secrets" (query-params namespace=normalizedNamespace)}} | ||
| class={{concat "is-block " class}} | ||
| data-test-namespace-link={{this.normalizedNamespace}} |
There was a problem hiding this comment.
why do we need the this. now?
There was a problem hiding this comment.
It's not required, but it's helpful to clarify what's state on the component, what's an argument to a component (@foo), and what's a helper. https://github.com/emberjs/rfcs/blob/master/text/0276-named-args.md has more about that. I should probably update the other use of normalizedNamespace too haha.
madalynrose
previously approved these changes
Jul 26, 2019
…d namespaces would not show up in the navigation
meirish
force-pushed
the
b-clear-namespaces
branch
from
defc5c5 to
86e0991
Compare
meirish
added a commit
that referenced
this pull request
Aug 5, 2019
…he namepace picker (#7186) * reset namespace cache when a user logs out * fix issue where if you log in to a namespace with an initial /, nested namespaces would not show up in the navigation * set an empty list of namespaces instead of ignoring error * add tests for namespace bugs * use this consistently in template
meirish
added a commit
that referenced
this pull request
Aug 5, 2019
* ancestorKeysForKey always returns an array (#6205) * clear namespaces on logout and properly render nested namespaces in the namepace picker (#7186) * reset namespace cache when a user logs out * fix issue where if you log in to a namespace with an initial /, nested namespaces would not show up in the navigation * set an empty list of namespaces instead of ignoring error * add tests for namespace bugs * use this consistently in template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two small namespace bugs:
/, the namespace-picker would not show any namespaces nested further down because the tree construction would try to match/foowithfoo.This PR fixes both of these issues.