Format requests/responses ahead of time in file audit #7024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was inspired by #7022 but has the advantage of avoiding double-locking and needing to perform lock upgrades while also simplifying the logic and being faster. Original, #7022, this: goos: linux goarch: amd64 pkg: github.com/hashicorp/vault/builtin/audit/file BenchmarkAuditFile_request-4 30000 60734 ns/op PASS ok github.com/hashicorp/vault/builtin/audit/file 2.428s goos: linux goarch: amd64 pkg: github.com/hashicorp/vault/builtin/audit/file BenchmarkAuditFile_request-4 50000 34772 ns/op PASS ok github.com/hashicorp/vault/builtin/audit/file 2.086s goos: linux goarch: amd64 pkg: github.com/hashicorp/vault/builtin/audit/file BenchmarkAuditFile_request-4 50000 25302 ns/op PASS ok github.com/hashicorp/vault/builtin/audit/file 1.542s Fixes #7014 Closes #7022
mgaffney
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
Nice performance improvement!
Results from benchcmp:
benchmark old ns/op new ns/op delta
BenchmarkAuditFile_request-12 50701 13330 -73.71%
benchmark old allocs new allocs delta
BenchmarkAuditFile_request-12 395 397 +0.51%
benchmark old bytes new bytes delta
BenchmarkAuditFile_request-12 16664 18897 +13.40%
vishalnayak
reviewed
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was inspired by #7022 but has the advantage of avoiding
double-locking and needing to perform lock upgrades while also
simplifying the logic and being faster.
Original, #7022, this:
Fixes #7014
Closes #7022